Okay
  Public Ticket #3028756
NewYork theme and PrestaShop 1.7.8.5 compatibility
Closed

Comments

  • David Georges started the conversation

    Hello, I'm a freelance web developer and I'm using your NewYork theme for a customer. I just upgraded PrestaShop to v1.7.8.5 and I get a lot of notices (Notice: Trying to access array offset on value of type null). I downloaded the last version on theme forest (v4.3.1) but the notices are still there. Are you aware of this problem? Regards, David.

  •  251
    Andrea replied

    Please provide us FTP credentials and Back Office access of your site.

    We will handle the problem to help you.

    Best Regards,

    Andrea - FieldThemes Support Team

  • David Georges replied

    Hello Andrea, thank you for your answer. It's not possible to give you a FTP access because of our security policy (we are deploying using GIT etc). 

    Could you please just answer my question? 

    - Are you aware of this problem?

    - Do you plan to publish a new version soon?


  •  251
    Andrea replied

    Hi
    Can you tell us what theme you are using? We will install and test it for you.
    We don't have this error when testing update with ps1.7.8.5
    Thanks

    Best Regards,

    Andrea - FieldThemes Support Team

  • David Georges replied

    Hello Andrea,

    We are using newyork_home1 Version 1.0.3 and since the update to PS 1.7.8.5 we get a lot of notices.

    Example (see capture). If I look in the code I find this:

    <div class="card-block-top">    
        <div class="totals-top">        
            <span class="label-top">{$cart.totals.total.label} {$cart.labels.tax_short}</span>        
            <span class="value-top price">{$cart.totals.total.value}</span>    
        </div>    
        <div class="totals-top">        
            <span class="label-top">{$cart.subtotals.tax.label}</span>        
            <span class="value-top price">{$cart.subtotals.tax.value}</span>    
        </div>
    </div>

    ... which is problematic if $cart.subtotals.tax is null.

    PrestaShop published a bugfix for that : https://github.com/PrestaShop/ps_shoppingcart/commit/5f509d300484a4c5af4488eaa34d503f3a628a71

    But your theme (in v4.3.1) don't seems to fix that.


  •  251
    Andrea replied

    Hi
    New York we have a lot of themes, you need to specify which theme it is (fashion, classic, jewelry, organico, ...)
    Theme newyork_home1 as you say is classic theme
    https://demo.fieldthemes.com/newyork/elementor/ps17/classic/en/
    We have updated it to version 1.3.0, ps_shopping_cart module is Pretashop's module and we do not interfere with its source code.
    We have reinstalled the theme and enabled debug_mode on preasthop 1.7.8.5, no error as you said.
    Thanks

    Best Regards,

    Andrea - FieldThemes Support Team

  • David Georges replied

    Hello Andrea,

    Ok I'll try to upgrade classic theme to v1.3.0.

    Do you have a documentation on how to upgrade?

  •  251
    Andrea replied

    Hi
    You see the changelog of the theme and update the changed modules for the theme update
    Thanks

    Best Regards,

    Andrea - FieldThemes Support Team

  • David Georges replied

    Hi Andrea,

    I would like to upgrade to whole theme (from 1.0.3 to v1.3.0). 

    Is there an automatic process?

  •  251
    Andrea replied

    Hi
    You have to manually update your theme, you see the changelog of each theme and update the necessary modules or templates.
    Thanks

    Best Regards,

    Andrea - FieldThemes Support Team

  •  8
    Thierry replied

    Hi, I have the same question.
    I fund the changelog.txt, but it doesn't list the necessary modules or templates to update...

    Attached files:  Capture d’écran 2022-05-12 à 10.26.00.png

  •  251
    Andrea replied

    Hi
    Small changes like js or template will be general. The major changes of the module will have the modules included on the update files. Which version do you want to update, we can guide you to the file to update.
    Thanks

    Best Regards,

    Andrea - FieldThemes Support Team

  •  8
    Thierry replied

    I have this version : petshop7 Version 2.5 (Prestashop 1.7.8.5)

    Attached files:  Capture d’écran 2022-05-12 à 15.50.21.png

  •  251
    Andrea replied

    Hi
    If you are using prestashop version 1.7.8.x, download the latest theme from themeforest and update the fieldproductcomments and fieldmegamenu modules. replace the theme.js file in \themes\name_theme\assets\js\theme.js
    Note: Backup your modules, files and pages before updating to avoid data loss

    Thanks

    Best Regards,

    Andrea - FieldThemes Support Team

  •  8
    Thierry replied

    Hi,
    Thanks. I updated.
    I have 2 Search boxes now.

    Attached files:  Capture d’écran 2022-05-13 à 10.46.52.png

  •  251
    Andrea replied

    Hi
    Did you check your page, does it contain hooks with the same module?
    The modules and js files I show you to update, it has nothing to do with your search box
    Thanks

    Best Regards,

    Andrea - FieldThemes Support Team

  •  8
    Thierry replied

    Hi,
    Ok, Thanks.

  •  251
    Andrea replied

    Hi
    Nice to help you, have a nice day
    Thank you for your interest in us

    Best Regards,

    Andrea - FieldThemes Support Team